Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] New Page for Visualizer Views #226

Merged
merged 20 commits into from
Mar 22, 2024
Merged

Conversation

nwanduka
Copy link
Contributor

@nwanduka nwanduka commented Mar 5, 2024

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Victoria Nduka <[email protected]>
Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for bejewelled-pegasus-b0ce81 ready!

Name Link
🔨 Latest commit 8c79a88
🔍 Latest deploy log https://app.netlify.com/sites/bejewelled-pegasus-b0ce81/deploys/65fd9fbabac9000007b11e59
😎 Deploy Preview https://deploy-preview-226--bejewelled-pegasus-b0ce81.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jameshorton2337
Copy link
Contributor

Looks good so far. 😉

@vishalvivekm
Copy link
Member

@nwanduka Let'd discuss this on websites call. Add this as an agenda item to the meeting minutes, if you would :)

@nwanduka nwanduka marked this pull request as ready for review March 11, 2024 12:01
nwanduka and others added 4 commits March 11, 2024 16:13
Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Archit Sharma <[email protected]>
Signed-off-by: Archit Sharma <[email protected]>
@iArchitSharma
Copy link
Contributor

@nwanduka, can you expand the content? It's nice to explain what you can do with Views. Can we also mention how to do it? For example, how you can export views.

Updated "export views" section

Signed-off-by: Victoria Nduka <[email protected]>
@nwanduka
Copy link
Contributor Author

@nwanduka, can you expand the content? It's nice to explain what you can do with Views. Can we also mention how to do it? For example, how you can export views.

Done @iArchitSharma. How is it now?

@iArchitSharma
Copy link
Contributor

Awesome @nwanduka
can you please do same for other things in managing views

Signed-off-by: Victoria Nduka <[email protected]>
Added screenshots

Signed-off-by: Victoria Nduka <[email protected]>
added screenshots

Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Victoria Nduka <[email protected]>
Signed-off-by: Victoria Nduka <[email protected]>
@nwanduka
Copy link
Contributor Author

@iArchitSharma I made a few changes. I'm facing some issues with the screenshots. They load in the markdown preview but not in the netlify preview. I can't figure out why but I think you can. Please review.

@iArchitSharma
Copy link
Contributor

@nwanduka
See the format here :
image

@nwanduka
Copy link
Contributor Author

Done @iArchitSharma

Copy link
Contributor

@iArchitSharma iArchitSharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@iArchitSharma iArchitSharma merged commit 0feca64 into layer5io:master Mar 22, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants